Gate startup on storage readiness for Before-First-Unlock recovery#710
Merged
Conversation
Collaborator
TestBuild onto SE 3rd gen, iOS 26 device. Reboot the phone but do not unlock it right away |
marionbarker
approved these changes
Jul 19, 2026
marionbarker
left a comment
marionbarker
left a comment
Collaborator
There was a problem hiding this comment.
Approve from code review and test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Gates app startup on storage readiness. Before a device's first unlock after a reboot (Before-First-Unlock / BFU), UserDefaults is encrypted and every stored value reads as its default. This detects that state via a presence sentinel, holds the UI behind a lightweight loading view until the store is readable, then hydrates every value and reconnects Bluetooth. Replaces the hand-maintained
reloadAll()recovery — values now register for hydration automatically, so none can be missed.Why
On a BFU background launch (BLE or background-refresh wake) the app otherwise acts on poisoned defaults: it re-prompts telemetry consent, runs with an empty Nightscout URL, and leaves the CGM heartbeat down after recovery. Ordinary locked launches are unaffected.
How to test
Requires a real device with a passcode (the Simulator can't reproduce BFU). Configure a data source, reboot the phone and — without unlocking — let a BLE/background wake fire. Then unlock and open the app; the logs should show
BFU check:andBFU recovery complete: url='…'. Expect no telemetry re-prompt, Bluetooth reconnected, and a non-empty url.Note
The BFU sentinel ORs a few presence probes (
migrationStep,telemetryConsentDecisionMade,url) alongside a dedicated marker, to correctly classify users who haven't launched this build yet. About a year after release — once all users are expected to have the marker — those extra probes can be dropped in favour of the marker alone.